Small adjustment to the Spinner. It looks better if having 12 rectangles instead of 10.#8
Open
phuhuynh2411 wants to merge 26 commits intoAppPear:masterfrom
Open
Small adjustment to the Spinner. It looks better if having 12 rectangles instead of 10.#8phuhuynh2411 wants to merge 26 commits intoAppPear:masterfrom
phuhuynh2411 wants to merge 26 commits intoAppPear:masterfrom
Conversation
…o the native iOS Spinner.
…vigationBarTitle() method - Allow users to turn off the refresh view, instead of auto closing it after 1 second.
+ Add inline.gif
Use without NavigationView
Owner
|
I think you might have commited a lot more then adding 2 rectangles, I'm afraid you have to cherry pick the right commit so I could merge it |
Author
I don't have a write permission, so I cannot do the git-cherry pick. Perhaps, can you do it? Here is the right commit hash cbe4e32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a small adjustment to the Spinner as below