Fix Framework/demo: add full server project and mithril workaround + docs refresh #3040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I DON'T have JIRA ticket
if it is new feature explain how plan to use ittest are addedFLP integration tests were ran successfulSummary
This PR makes the demo applications in
Framework/docs/demo/actually runnable. Until now, all demo pages would stall onLoading…because the framework’s renderer.js imports Mithril from an absolute path. Unless Mithril is provided at that path, the browser request 404s,window.mnever exists, and the demos cannot render. The problem appears both when serving files locally with a static server as well as the hosted GitHub Pages demo (see the Advanced frontend demo).What this PR does
Framework/docs/demo/project/HttpServerfrom WebUi./frontend,/chart,/notification,/template-1,/template-2)./mithril/mithril.min.jsand serve docs statically.Framework/README.md:Why this is needed
/mithril/mithril.min.js.Next steps / open questions
/mithrilfolder or switched to a CDN import?renderer.jsto allow overriding the Mithril URL viawindow.WEBUI_MITHRIL_URL./mithril/mithril.min.js. Fixing the hosted demo (e.g. by publishing Mithril at the site root or switching the import to a CDN) is out of scope for this PR.