[PWGJE] modify the delta pT methods#13984
Closed
Hamwooseok wants to merge 1 commit intoAliceO2Group:masterfrom
Closed
[PWGJE] modify the delta pT methods#13984Hamwooseok wants to merge 1 commit intoAliceO2Group:masterfrom
Hamwooseok wants to merge 1 commit intoAliceO2Group:masterfrom
Conversation
Hamwooseok
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 1 errors, |
github-actions
bot
changed the title
Contributor
Author
|
Collaborator
|
@aimeric-landou are you ok with the changes to this task? |
Contributor
|
@nzardosh yes it looks good to me; |
nzardosh
approved these changes
Dec 10, 2025
fjonasALICE
reviewed
Dec 18, 2025
| @@ -119,32 +119,36 @@ struct JetBackgroundAnalysisTask { | |||
| float randomConeEta = randomNumber.Uniform(trackEtaMin + randomConeR, trackEtaMax - randomConeR); | |||
Collaborator
There was a problem hiding this comment.
as random number generation is expensive, consider moving this into the
if (jets.size() > 0){
...
}
same for the other occurences
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify the filling method so that delta pT is not filled in events without jets.