[PWGJE] trackEfficiency: FT0M or C for centrality, other fixes/cleaning#13729
Merged
nzardosh merged 3 commits intoAliceO2Group:masterfrom Nov 21, 2025
Merged
[PWGJE] trackEfficiency: FT0M or C for centrality, other fixes/cleaning#13729nzardosh merged 3 commits intoAliceO2Group:masterfrom
nzardosh merged 3 commits intoAliceO2Group:masterfrom
Conversation
Contributor
aimeric-landou
commented
Nov 7, 2025
aimeric-landou
commented
- add filter (posZ) to collision iterators
- fix processTrackSelectionHistograms subscription
- clean some comments in code
- simPtRef now global
- fix default cent binning
- single line for centrality declaration
- checkCentrality renamed cutCentrality
…y, add filter (posZ) to collision iterators, fix processTrackSelectionHistograms subscription, clean some comments in code, simPtRef now global, fix default cent binning, single line for centrality declaration, checkCentrality renamed cutCentrality
aimeric-landou
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 73a071a at 2025-11-08 06:50: Full log here. |
nzardosh
reviewed
Nov 10, 2025
PWGJE/Tasks/trackEfficiency.cxx
Outdated
| registry.fill(HIST("hMcCollCutsCounts"), 4.5, mcCollision.weight()); // at least one of the reconstructed collisions associated with this mcCollision is selected | ||
|
|
||
| if (!centralityCheck) { | ||
| float centrality = checkCentFT0M ? centrality = mcCollision.centFT0M() : centrality = mcCollision.centFT0C(); |
Collaborator
There was a problem hiding this comment.
Hi Aimeric. It seems the centFT0C tables are not calibrated and filled by LF for mcCollisions. I am making a PR to remove them entirely from our data model. Could you remove them in this PR too please?
… to processTracksMc and processTrackSelectionHistograms
nzardosh
previously approved these changes
Nov 20, 2025
Collaborator
|
Error while checking build/O2Physics/o2 for 3e01b91 at 2025-11-21 11:15: Full log here. |
auto-merge was automatically disabled
November 21, 2025 11:08
Head branch was pushed to by a user without write access
nzardosh
approved these changes
Nov 21, 2025
lmattei01
pushed a commit
to lmattei01/O2Physics
that referenced
this pull request
Dec 5, 2025
MattOckleton
pushed a commit
to MattOckleton/O2Physics
that referenced
this pull request
Jan 14, 2026
mapalhares
pushed a commit
to mapalhares/O2Physics
that referenced
this pull request
Jan 20, 2026
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
karlazertova
pushed a commit
to karlazertova/O2Physics
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.