Skip to content

Config oo pp ne#2044

Merged
shahor02 merged 5 commits intoAliceO2Group:masterfrom
cpuggion84:config_oo_pp_ne
Jul 31, 2025
Merged

Config oo pp ne#2044
shahor02 merged 5 commits intoAliceO2Group:masterfrom
cpuggion84:config_oo_pp_ne

Conversation

@cpuggion84
Copy link
Contributor

@cpuggion84 cpuggion84 commented Jul 2, 2025

  • New configuration for oxigen proton and Neon
  • Fixed bug bin in Pb-Pb
  • Add Data Source Post Processing

cpuggion84 added 4 commits July 2, 2025 18:30
@cpuggion84
Update zdc.json
2ead5c9 
new config for oxigen, proton and ne
@cpuggion84
Update zdcPbPb.json
86e5aec
@cpuggion84
Update zdcPbPb.json
8ca4ebd 
fixed error bin in histograms TDCAZEMvsTDCT
@cpuggion84
Update zdc.json
745450e 
Add Data sources for Post Processing
@github-actions
Copy link

github-actions bot commented Jul 2, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@cpuggion84
Copy link
Contributor Author

cpuggion84 commented Jul 2, 2025

I would need to add a label related to the oxygen and neon period 2025 but I don't see any in the list
Cheers
Carlo

@JianLIUhep
Copy link
Contributor

JianLIUhep commented Jul 3, 2025

Hi @alcaliva @catalinristea, I tested the changes locally and it looked ok.
Could you please merge it, and if possible, include this PR in OO, NeNe and also upcoming pO productions?

@alcaliva alcaliva enabled auto-merge (squash) July 3, 2025 09:08
@cpuggion84
Update zdc.json
969c1e5 
Adjust Bin TDCAH and ADCH
auto-merge was automatically disabled July 3, 2025 12:53

Head branch was pushed to by a user without write access

cpuggion84
cpuggion84 commented Jul 3, 2025
View reviewed changes
Copy link
Contributor Author

@cpuggion84 cpuggion84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjust bin ADCH and TDCH

@cpuggion84 cpuggion84 requested a review from alcaliva July 4, 2025 09:59
@alcaliva alcaliva enabled auto-merge (squash) July 4, 2025 10:11
@JianLIUhep
Copy link
Contributor

JianLIUhep commented Jul 7, 2025

Hi @alcaliva, could we merge this PR and have it in the upcoming OO, NeNe and pO productions whenever possible?
Thanks a lot.

@alcaliva
Copy link
Collaborator

alcaliva commented Jul 7, 2025

Hi @JianLIUhep ,
we will run apass1 using the tag from dev/master, so your PR will be included.
Be aware that right now we cannot build software tagged from master due to a problem in Jenkins.
Experts are working on this issue and we expect it to be solved soon.

Alberto

@alcaliva
Copy link
Collaborator

alcaliva commented Jul 31, 2025

Dear @davidrohr and @shahor02,
could you please merge this PR?

@shahor02 shahor02 disabled auto-merge July 31, 2025 12:41
@shahor02 shahor02 merged commit 53f4030 into AliceO2Group:master Jul 31, 2025
7 checks passed
alcaliva pushed a commit that referenced this pull request Jul 31, 2025
@cpuggion84 @alcaliva
Config oo pp ne (#2044)
3e77491 
* Update zdc.json

new config for oxigen, proton and ne

* Update zdcPbPb.json

* Update zdcPbPb.json

fixed error bin in histograms TDCAZEMvsTDCT

* Update zdc.json

Add Data sources for Post Processing

* Update zdc.json

Adjust Bin TDCAH and ADCH
alcaliva pushed a commit that referenced this pull request Jul 31, 2025
@cpuggion84 @alcaliva
Config oo pp ne (#2044)
2317200 
* Update zdc.json

new config for oxigen, proton and ne

* Update zdcPbPb.json

* Update zdcPbPb.json

fixed error bin in histograms TDCAZEMvsTDCT

* Update zdc.json

Add Data sources for Post Processing

* Update zdc.json

Adjust Bin TDCAH and ADCH
alcaliva pushed a commit that referenced this pull request Jul 31, 2025
@cpuggion84 @alcaliva
Config oo pp ne (#2044)
9eb2726 
* Update zdc.json

new config for oxigen, proton and ne

* Update zdcPbPb.json

* Update zdcPbPb.json

fixed error bin in histograms TDCAZEMvsTDCT

* Update zdc.json

Add Data sources for Post Processing

* Update zdc.json

Adjust Bin TDCAH and ADCH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alcaliva alcaliva alcaliva approved these changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpuggion84 @JianLIUhep @alcaliva @shahor02