Skip to content

Conversation

@Houwie7000
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Beam types filter added to LHCfills page.

Notable changes for developers:

  • Request is done to the backend to retrieve the possible beamtypes from the DB
  • oneOfOrNull function added to QueryBuilder.js

Changes made to the database:

@Houwie7000 Houwie7000 self-assigned this Dec 16, 2025
@Houwie7000 Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 59.67742% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.68%. Comparing base (4e68523) to head (92c7f4f).
⚠️ Report is 1 commits behind head on feature/O2B-1506/lhcfills-run-duration-filter.

Files with missing lines Patch % Lines
...nts/Filters/LhcFillsFilter/BeamsTypeFilterModel.js 0.00% 14 Missing ⚠️
...b/public/services/beamsTypes/beamsTypesProvider.js 0.00% 4 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 3 Missing ⚠️
...mponents/Filters/LhcFillsFilter/beamsTypeFilter.js 0.00% 2 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
lib/server/controllers/beamsTypes.controller.js 92.30% 1 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                @@
##           feature/O2B-1506/lhcfills-run-duration-filter    #2045      +/-   ##
=================================================================================
+ Coverage                                          45.63%   45.68%   +0.04%     
=================================================================================
  Files                                               1031     1039       +8     
  Lines                                              17190    17265      +75     
  Branches                                            3130     3137       +7     
=================================================================================
+ Hits                                                7845     7887      +42     
- Misses                                              9345     9378      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 marked this pull request as ready for review January 22, 2026 15:51
@Houwie7000 Houwie7000 requested a review from graduta as a code owner January 22, 2026 15:51
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1508/lhcfills-beam-types-filter branch from a61c2a0 to ac739fe Compare January 22, 2026 16:10
@Houwie7000
Copy link
Collaborator Author

Push -f for typo in commit [1508] vs [O2B-1508]

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1508/lhcfills-beam-types-filter branch from ac739fe to 475c273 Compare January 22, 2026 16:16
@Houwie7000
Copy link
Collaborator Author

Push -f for wrongly included files

Replaces raw SQL query for fetching distinct beam types with a Sequelize-based implementation.
Eliminated the ability to filter LHC fills by 'null' beamType values.

Updates repository to exclude null beam types in distinct queries.

Removed the oneOfOrNull method from QueryBuilder.

Simplifies the beam type filtering in GetAllLhcFillsUseCase by removing the special handling for 'null' values.

Adjusts related tests to match the new logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants