-
Notifications
You must be signed in to change notification settings - Fork 21
[O2B-1508] LHCfills beam types filter #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/O2B-1506/lhcfills-run-duration-filter
Are you sure you want to change the base?
[O2B-1508] LHCfills beam types filter #2045
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/O2B-1506/lhcfills-run-duration-filter #2045 +/- ##
=================================================================================
+ Coverage 45.63% 45.68% +0.04%
=================================================================================
Files 1031 1039 +8
Lines 17190 17265 +75
Branches 3130 3137 +7
=================================================================================
+ Hits 7845 7887 +42
- Misses 9345 9378 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ture/O2B-1508/lhcfills-beam-types-filter
…ture/O2B-1508/lhcfills-beam-types-filter update from upstream
…ture/O2B-1508/lhcfills-beam-types-filter
a61c2a0 to
ac739fe
Compare
|
Push -f for typo in commit [1508] vs [O2B-1508] |
ac739fe to
475c273
Compare
|
Push -f for wrongly included files |
Replaces raw SQL query for fetching distinct beam types with a Sequelize-based implementation.
Eliminated the ability to filter LHC fills by 'null' beamType values. Updates repository to exclude null beam types in distinct queries. Removed the oneOfOrNull method from QueryBuilder. Simplifies the beam type filtering in GetAllLhcFillsUseCase by removing the special handling for 'null' values. Adjusts related tests to match the new logic.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: