[AFIT-112]: FT0's reco update, 3 new event bits#14123
[AFIT-112]: FT0's reco update, 3 new event bits#14123shahor02 merged 5 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
+async-label async-2023-pbpb-apass4, async-2023-pp-apass4, async-2024-pp-apass1, async-2022-pp-apass7, async-2024-pp-cpass0, async-2024-PbPb-apass1, async-2024-ppRef-apass1, async-2024-PbPb-apass2, async-2023-PbPb-apass5 |
8f3f92c to
706c483
Compare
|
tests on macros failed? This PR does not contain any ROOT macros |
|
@afurs could you rebase your branch to dev? |
AFIT-112: hotfix AFIT-112: hotfix
|
Hello @shahor02 , done. |
shahor02
left a comment
There was a problem hiding this comment.
Looks fine but I would prefer this to be validated by FT0. Since you want it to be used for the next Pb passes: did you test it?
Do you mean approve from FT0 experts? Codeowners(@jotwinow @andreasmolander ) or somebody else? I also attached(first comment and branch name as ID) JIRA ticket related to this PR, ticket was approved by FIT team at the "FIT Software Meeting" on 2024/02/27 An only difference is that I decided also to keep tech bits within rec point entity for next reco QC patch (will be prepared just right after this PR is merged) |
|
hotfix is needed |
|
Actually we need to reconsider AliceO2/DataFormats/Detectors/FIT/common/include/DataFormatsFIT/Triggers.h Lines 135 to 140 in 1102011 ChannelData entities at CTF reading stage, w/o any calibration correction. Only trigger field is required for recpoints. But I will keep old logic just in case.
|
|
@shahor02 I tested again, only found minor incorrectness in the fields I mentioned above in comment. Hotfix applied. I think once some one from FT0 approve this we can go with merging (after successful CICD of course :) ), ok? |
|
Error while checking build/O2/fullCI_slc9 for fd24c67 at 2025-04-01 11:38: Full log here. |
|
@shahor02 rebase again? Unrelated issues came in CICD |
|
@afurs it was a ccdb timeout after the main part of the FST was passed, ignore this. |
|
@shahor02 only |
|
@afurs that's ok, shall I merge it? |
|
@shahor02 yes, please |
https://its.cern.ch/jira/browse/AFIT-112