Added Identity operator#238
Merged
wipsel merged 2 commits intoAdvancedClimateSystems:developfrom Mar 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds the new Identity operator to support ONNX identity functionality and includes corresponding tests. Key changes include:
- Adding the Identity operator implementation (ops/identity/identity.go) and its versioning file (ops/identity/versions.go).
- Updating the operator map in opset.go to include the Identity operator.
- Adding unit tests for the Identity operator in ops/identity/identity_test.go and updating test lists in ops_test.go.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| opset.go | Added import and map entry for the Identity operator. |
| ops_test.go | Updated test lists to include Identity operator tests and an ignored "test_identity_opt". |
| ops/identity/versions.go | Created versioning for the Identity operator. |
| ops/identity/identity_test.go | Added tests validating the behavior and inputs of the Identity operator. |
| ops/identity/identity.go | Implemented the Identity operator functionality. |
Comments suppressed due to low confidence (1)
ops_test.go:85
- [nitpick] Consider clarifying the comment for 'test_identity_opt' to provide explicit context or a reference to a bug report if this test is intentionally ignored due to a known issue.
"test_identity_opt", // Bug in test? Can't read in input tensor.
wipsel
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48