Ampers: Mariko, Kate, and Katie by kcforsman · Pull Request #10 · Ada-C9/VideoStoreAPI

kcforsman · 2018-05-11T21:26:45Z

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We based it on the seed data. We talked through it and then pulled up the seed data to assign specific names attributes. That is all.
Describe a set of positive and negative test cases you implemented for a model.	We checked that something must be valid with particular attribute (in the case of a customer that all attributes are present). For a negative case, that a model was invalid without certain fields (for example, a customer need a name).
Describe a set of positive and negative test cases you implemented for a controller.	A rental can be created for an existing customer and an existing movie in the checkout action, which confirms that a record of a rental is created. A rental cannot be created if there is no available inventory, and the rental count doesn't change.
How does your API respond when bad data is sent to it?	ok: false, error: "some message related to the problem" or model.errors and either the :not_found for :bad_request
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We didn't do any though we could always pulled out some the logic to build either the new movie or a rental and to handle inventory management. But given the size of the project, I think we ended up just leaving it all in the controllers (may to be refactored later?)
Do you have any recommendations on how we could improve this project for the next cohort?	More information around testing in PostMan, like how to interpret the smoke tests. More practice with navigating what one might call legacy code including tests.
Link to Trello	https://trello.com/b/0hyMWkKX/blockbuster-thing
Link to ERD	https://www.lucidchart.com/documents/edit/11605e6a-0450-4ae8-8431-b2d65885cc3e

…ure_model-test

Feature model test

… and customers controllers with appropriate actions

…l do testing next

merge with movie controller actions

…r empty array if there are no existing customers

… index test

…entory, and altered seed.rb to set the value equal to json inventory values

…ion and updated test for new field

…ntroller creates tests for the create method in the movies controller

changes code to get smoke tests working

…ontroller

…e tests and added more details to the negative tests

creates test for movie relationships to rentals

adds tests for rental model validation tests and relationship tests

relationship testing customer has many rentals

… the controller and use strong params, and fixed movie controller tests to respect foreign key violation

…nteresting' changes to occur on the available_inventory of movies and the movies_checkout_count for a customer

…nnot exceed the inventory for a movie

…vie count

… edited yml files

…to yaml

CheezItMan · 2018-05-13T04:09:31Z

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good commit messages and good number of commits, all team members participated
Comprehension questions	Check,
General
Business Logic in Models	MISSING you're doing all your logic in the controller. Not a good idea.
All required endpoints return expected JSON data	Check
Requests respond with appropriate HTTP Status Code	. Check
Errors are reported	Check
Testing
Passes all Smoke Tests	Check
Model Tests - all relations, validations, and custom functions test positive & negative cases	Check
Controller Tests - URI parameters and data in the request body have positive & negative cases	You are failing tests you'd started for overdue rentals. Just a note they are optional, good that you got to start on them.
Overall	Small note: I assume it's good, but I don't have access to your ERD. You hit all the requirement for the project, nice work, congratulations, you are finished with Rails!

CheezItMan · 2018-05-13T03:53:41Z

app/controllers/rentals_controller.rb

+    if customer && movie
+      if movie.available_inventory > 0
+        rental = Rental.new(customer: customer, movie: movie, checkout_date: Date.today, due_date: Date.today + 7.days)
+        customer.movies_checked_out_count += 1


This kind of business logic really doesn't go here.

CheezItMan · 2018-05-13T03:53:53Z

app/controllers/rentals_controller.rb

+      rental = Rental.find_by(customer: customer, movie: movie, returned: false)
+      if rental
+        rental.returned = true
+        customer.movies_checked_out_count -= 1


ditto on business logic

CheezItMan · 2018-05-13T04:04:54Z

test/models/customer_test.rb

+
+      it "can have no rentals" do
+        customer = customers(:shell)
+        customer.rentals.length.must_equal 1


Why are you testing for a rental length of 1, if there are no rentals?

CheezItMan · 2018-05-13T04:07:31Z

test/controllers/movies_controller_test.rb

+      body.must_include "id"
+
+      # Check that the ID matches
+      Movie.find(body["id"]).title.must_equal "The Princess Bride"


Great movie 👍

kcforsman and others added 30 commits May 7, 2018 12:44

new rails project for api setup complete

9622481

generated customer and movie models to match seed data/ERD

9ea204a

adds tests for customer model and validations

01e65d5

creates model validations and tests

dce714d

Merge branch 'master' of github.com:kcforsman/VideoStoreAPI into feat…

4cf305f

…ure_model-test

Merge pull request #1 from kcforsman/feature_model-test

13effd2

Feature model test

added routes for movies and customers endpoints, and generated movies…

85421ec

… and customers controllers with appropriate actions

added method to the index action in the Movies Controller...oops we'l…

0198d23

…l do testing next

adds customer controller index action

242ddf4

Merge branch 'master' of https://github.com/kcforsman/VideoStoreAPI

048a402

merge with movie controller actions

adds movies_checked_out_count to customers model

013f21d

adds movies_checked_out_count to customer controller

4d32360

added nominal customer controller tests for the index action

7b1b37c

updated customers controller test for index action to include test fo…

29ad211

…r empty array if there are no existing customers

movies index controlller tests

1532046

Merge branch 'master' of https://github.com/kcforsman/VideoStoreAPI

3b15c18

adds all movies controller index tests, refactors customer controller…

c1eaa88

… index test

updates movies yml file to have valid data (4 total)

657d931

TDD for show action in movie controller

b805ebc

created two migration to add column to movies table for available_inv…

d6e6f5c

…entory, and altered seed.rb to set the value equal to json inventory values

added available_inventory to the json response for the movie show act…

919906f

…ion and updated test for new field

creates tests for the create method in the movies controller

a558f66

adds protect_from_forgery

b9aee67

creates code for the create method for movies

a85bafe

remove commented out code

54b59e4

Merge pull request #2 from kcforsman/feature_tests-and-code-movies-co…

24140d2

…ntroller creates tests for the create method in the movies controller

changes code to get smoke tests working

b57162e

Merge pull request #3 from kcforsman/ex_removing-movie-from-params

036da8d

changes code to get smoke tests working

generated Rental model with necessary attributes

5ef36b2

updated schema with the rental model details

4544050

marikoja and others added 16 commits May 8, 2018 12:58

tets for RentalsController checkout and check_out action for RentalsC…

7fa7579

…ontroller

refactored check out action in rental controller to pass negative cas…

7445271

…e tests and added more details to the negative tests

rentals_controller check_in code and error handling and testing

e853e4c

creates test for movie relationships to rentals

9457dd4

Merge pull request #4 from kcforsman/feature_movie-relationship-test

d39749b

creates test for movie relationships to rentals

adds tests for rental model validation tests and relationship tests

dbceeda

Merge pull request #5 from kcforsman/rental-model-tests

ca24b26

adds tests for rental model validation tests and relationship tests

relationship testing customer has many rentals

84f65cb

Merge pull request #6 from kcforsman/customer_relationship_testing

212180a

relationship testing customer has many rentals

changed the movie create method to set the available inventory within…

1243782

… the controller and use strong params, and fixed movie controller tests to respect foreign key violation

added logic to rental controller checkout and checkin to allow for 'i…

52e87d0

…nteresting' changes to occur on the available_inventory of movies and the movies_checkout_count for a customer

added conditional for rental check_out method so number of rentals ca…

fdbce8c

…nnot exceed the inventory for a movie

updates yml files to account for available inventory and customers mo…

88cad2e

…vie count

updated tests to handle foreign key violations from adjusted code and…

6528651

… edited yml files

rentals controller tests checkout inventory management

c931c6e

rental controller tests for checkin inventory management and updates …

445f1dc

…to yaml

CheezItMan reviewed May 13, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ampers: Mariko, Kate, and Katie#10

Ampers: Mariko, Kate, and Katie#10
kcforsman wants to merge 46 commits intoAda-C9:masterfrom
kcforsman:master

kcforsman commented May 11, 2018

Uh oh!

CheezItMan commented May 13, 2018

Uh oh!

CheezItMan May 13, 2018

Uh oh!

CheezItMan May 13, 2018

Uh oh!

CheezItMan May 13, 2018

Uh oh!

CheezItMan May 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kcforsman commented May 11, 2018

Video Store API

Comprehension Questions

Uh oh!

CheezItMan commented May 13, 2018

Video Store

What We're Looking For

Uh oh!

CheezItMan May 13, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 13, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 13, 2018

Choose a reason for hiding this comment

Uh oh!

CheezItMan May 13, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants