From 079b66973175e214616203af92d43e4d0d66d696 Mon Sep 17 00:00:00 2001 From: Ilan Gold Date: Thu, 12 Feb 2026 23:04:56 +0100 Subject: [PATCH 1/4] fix: remove now-dead fill_value handling --- python/zarrs/utils.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/python/zarrs/utils.py b/python/zarrs/utils.py index 2f483de..a091c12 100644 --- a/python/zarrs/utils.py +++ b/python/zarrs/utils.py @@ -170,14 +170,6 @@ def make_chunk_info_for_rust_with_indices( _, ) in batch_info: write_empty_chunks = chunk_spec.config.write_empty_chunks - if chunk_spec.fill_value is None: - chunk_spec = ArraySpec( - chunk_spec.shape, - chunk_spec.dtype, - get_implicit_fill_value(chunk_spec.dtype, chunk_spec.fill_value), - chunk_spec.config, - chunk_spec.prototype, - ) out_selection_as_slices = selector_tuple_to_slice_selection(out_selection) chunk_selection_as_slices = selector_tuple_to_slice_selection(chunk_selection) shape_chunk_selection_slices = get_shape_for_selector( From f0c59471f958a7c74fb2c07a092926d7588e6b88 Mon Sep 17 00:00:00 2001 From: Ilan Gold Date: Thu, 12 Feb 2026 23:15:02 +0100 Subject: [PATCH 2/4] fix: pre-commit --- python/zarrs/utils.py | 1 - 1 file changed, 1 deletion(-) diff --git a/python/zarrs/utils.py b/python/zarrs/utils.py index a091c12..5049ae6 100644 --- a/python/zarrs/utils.py +++ b/python/zarrs/utils.py @@ -7,7 +7,6 @@ from typing import TYPE_CHECKING, Any import numpy as np -from zarr.core.array_spec import ArraySpec from zarr.core.indexing import SelectorTuple, is_integer from zarrs._internal import ChunkItem From e5501895b31bccb727f2b2de5b7ec3561d613598 Mon Sep 17 00:00:00 2001 From: Ilan Gold Date: Thu, 12 Feb 2026 23:16:06 +0100 Subject: [PATCH 3/4] fix: imports --- python/zarrs/utils.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/zarrs/utils.py b/python/zarrs/utils.py index 5049ae6..661a4d7 100644 --- a/python/zarrs/utils.py +++ b/python/zarrs/utils.py @@ -7,7 +7,7 @@ from typing import TYPE_CHECKING, Any import numpy as np -from zarr.core.indexing import SelectorTuple, is_integer +from zarr.core.indexing import is_integer from zarrs._internal import ChunkItem @@ -17,6 +17,8 @@ from zarr.abc.store import ByteGetter, ByteSetter from zarr.dtype import ZDType + from zarr.core.array_spec import ArraySpec + from zarr.core.indexing import SelectorTuple # adapted from https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.ThreadPoolExecutor From c29498c6df7416461a035e94bdb2f5b06c7dc55d Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 12 Feb 2026 22:16:12 +0000 Subject: [PATCH 4/4] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- python/zarrs/utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/zarrs/utils.py b/python/zarrs/utils.py index 661a4d7..8a314a7 100644 --- a/python/zarrs/utils.py +++ b/python/zarrs/utils.py @@ -16,9 +16,9 @@ from types import EllipsisType from zarr.abc.store import ByteGetter, ByteSetter - from zarr.dtype import ZDType from zarr.core.array_spec import ArraySpec from zarr.core.indexing import SelectorTuple + from zarr.dtype import ZDType # adapted from https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.ThreadPoolExecutor