Behavior change in 0.13 for cells with valueType == null

[tfmorris]

We have a pending update to 0.13 from 0.12 which has failing CI tests, apparently because the values returned by OdfTableCell.getValueType() have changed from null in 0.12 to "string" in 0.13 for some cells at the end of rows.

Is this expected behavior? I didn't see anything in the release notes.

What is the best way to detect empty cells in a row?

[svanteschubert]

@tfmorris It is a good question...

Let me see...
@office:value-type is not an ODF default value,
https://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part1.html#attribute-office_value-type

Since ODF 1.3. I am extracting the values into a separate file from the ODF specification via XSLT:
https://github.com/oasis-tcs/odf-tc/blob/master/docs/odf1.3/content.odf13-default-values.xml

ODF applications might have a default value, like LibreOffice:
https://wiki.documentfoundation.org/Development/ODF_Implementer_Notes/List_of_LibreOffice_ODF_implementation-defined_items
But it is not a default...

Now let me double-check your claim:

1. https://github.com/tdf/odftoolkit/blob/master/odfdom/src/main/java/org/odftoolkit/odfdom/doc/table/OdfTableCell.java#L658
2. https://github.com/tdf/odftoolkit/blob/master/odfdom/src/main/java/org/odftoolkit/odfdom/dom/element/table/TableTableCellElementBase.java#L286

I do not see any default to String; there is null being returned when no attribute @office:value-type exists.
Can you please provide a testable/debuggable test?

PS: Or even better, please pinpoint where the difference is, as you got the regression test suite! Thanks in advance! :-)

[svanteschubert]

Any idea why getValueType is missing from the 0.13.0 API change log for OdfTableCell?
https://tdf.github.io/odftoolkit/api/odfdom-api-changes-0.12.0-0.13.0.html#org.odftoolkit.odfdom.doc.table.OdfTableCell

Did I miss a detail somewhere?