generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 633
feat(hooks): Add hook decorator #1581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkmeral
wants to merge
11
commits into
strands-agents:main
Choose a base branch
from
mkmeral:fix/hook-decorator-review-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+930
−9
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3eb4f65
feat(hooks): add @hook decorator for simplified hook definitions
strands-agent 80b4b04
fix(hooks): fix mypy type errors for hook decorator
strands-agent ca704f3
feat(hooks): add automatic agent injection to @hook decorator
strands-agent ca56c91
test(hooks): add comprehensive tests for @hook decorator coverage
strands-agent 70689a0
fix(hooks): address review comments for @hook decorator
9013876
docs: simplify docstrings, remove implementation details
a07be6a
refactor: remove unused logger, simplify class docstring
733156f
refactor: remove agent injection, simplify @hook decorator
b576d43
docs: update PR description
20643c7
Merge branch 'main' into fix/hook-decorator-review-fixes
mkmeral 89ed654
chore: delete description
mkmeral File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Should
FunctionHookMetadataandHookMetadatabe part of the public API?Looking at the
@tooldecorator pattern,FunctionToolMetadatais not exported publicly. These classes appear to be implementation details used internally by the decorator.Suggestion: Consider either:
__all__to keep them internal (consistent with @tool)The
DecoratedFunctionHookclass is appropriately public since users may needisinstancechecks.