Skip to content

Have user supplied attributes take precedence over exception-derived attributes #7993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Have user supplied attributes take precedence over exception-derived attributes #7993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5106802
Have user supplied attributes take precedence over exception-derived …
trask Jan 20, 2026
56ed6ee
setExceptionAttribute
trask Feb 3, 2026
13879e1
Re-order test to exercise precedence
trask Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion sdk/logs/src/main/java/io/opentelemetry/sdk/logs/ExtendedSdkLogRecordBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public ExtendedSdkLogRecordBuilder setException(Throwable throwable) {
loggerSharedState
.getExceptionAttributeResolver()
.setExceptionAttributes(
this::setAttribute,
this::setExceptionAttribute,
throwable,
loggerSharedState.getLogLimits().getMaxAttributeValueLength());

Expand Down Expand Up @@ -154,4 +154,17 @@ public void emit() {
body,
extendedAttributes));
}

/**
* Sets an exception-derived attribute only if it hasn't already been set by the user. This
* ensures user-set attributes take precedence over exception-derived attributes.
*/
private <T> void setExceptionAttribute(AttributeKey<T> key, @Nullable T value) {
if (key == null || key.getKey().isEmpty() || value == null) {
return;
}
if (extendedAttributes == null || extendedAttributes.get(key) == null) {
setAttribute(key, value);
}
}
}
23 changes: 23 additions & 0 deletions sdk/logs/src/testIncubating/java/io/opentelemetry/sdk/logs/ExtendedLoggerBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,27 @@ public void setExceptionAttributes(
equalTo(EXCEPTION_TYPE, "type"),
equalTo(EXCEPTION_STACKTRACE, "stacktrace")));
}

@Test
void setException_UserAttributesTakePrecedence() {
Logger logger = loggerProviderBuilder.build().get("logger");

((ExtendedLogRecordBuilder) logger.logRecordBuilder())
.setAttribute(EXCEPTION_MESSAGE, "custom message")
.setException(new Exception("error"))
.emit();
Copy link
Member

@jack-berg jack-berg Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user exception.message should take priority regardless of the invocation order yeah?

Copy link
Member Author

@trask trask Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13879e1


assertThat(exporter.getFinishedLogRecordItems())
.satisfiesExactly(
logRecord ->
assertThat(logRecord)
.hasAttributesSatisfyingExactly(
equalTo(EXCEPTION_TYPE, "java.lang.Exception"),
equalTo(EXCEPTION_MESSAGE, "custom message"),
satisfies(
EXCEPTION_STACKTRACE,
stacktrace ->
stacktrace.startsWith(
"java.lang.Exception: error" + System.lineSeparator()))));
}
}
Loading