From b447856a1f6691c1d2211531a46b120e2a4aa935 Mon Sep 17 00:00:00 2001
From: Benjamin Pollack <benjamin@ngrok.com>
Date: Wed, 18 Feb 2026 22:03:59 +0000
Subject: [PATCH] ci: fix docs.yml to use upload-pages-artifact@v3 +
 deploy-pages@v4

The old approach of manually tarring and using upload-artifact is not
compatible with modern deploy-pages. Use the proper upload-pages-artifact
action which handles the archive format that deploy-pages expects.
---
 .github/workflows/docs.yml | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 39c9878..10d1d1c 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -10,8 +10,8 @@ jobs:
     name: Javadocs
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-java@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-java@v4
         with:
           java-version: |
             17
@@ -20,14 +20,10 @@ jobs:
           cache: "maven"
       - name: Build Javadocs
         run: mvn javadoc:aggregate -Dmaven.javadoc.skippedModules=ngrok-java-native
-      - name: Archive Javadoc site
-        run: tar --directory target/site/apidocs -cvf "$RUNNER_TEMP/artifact.tar" .
-      - name: Upload Archive
-        uses: actions/upload-artifact@v1
+      - name: Upload Pages artifact
+        uses: actions/upload-pages-artifact@v3
         with:
-          name: github-pages
-          path: ${{ runner.temp }}/artifact.tar
-          retention-days: ${{ inputs.retention-days }}
+          path: target/site/apidocs
 
   deploy:
     needs: gen-javadocs
@@ -46,4 +42,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v1
+        uses: actions/deploy-pages@v4