Skip to content

chore: Update external account schemas from webdev #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lightspark-copybara wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Update external account schemas from webdev #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 38 additions & 32 deletions openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,40 @@
oneOf:
- title: US Account
$ref: ./UsAccountExternalAccountInfo.yaml
- title: CLABE Account
$ref: ./ClabeAccountExternalAccountInfo.yaml
- title: PIX Account
$ref: ./PixAccountExternalAccountInfo.yaml
- title: IBAN Account
$ref: ./IbanAccountExternalAccountInfo.yaml
- title: UPI Account
$ref: ./UpiAccountExternalAccountInfo.yaml
- title: NGN Account
$ref: ./NgnAccountExternalAccountInfo.yaml
- title: CAD Account
$ref: ./CadAccountExternalAccountInfo.yaml
- title: GBP Account
$ref: ./GbpAccountExternalAccountInfo.yaml
- title: PHP Account
$ref: ./PhpAccountExternalAccountInfo.yaml
- title: SGD Account
$ref: ./SgdAccountExternalAccountInfo.yaml
- title: Spark Wallet
$ref: ./SparkWalletExternalAccountInfo.yaml
- title: Lightning
$ref: ./LightningExternalAccountInfo.yaml
- title: Solana Wallet
$ref: ./SolanaWalletExternalAccountInfo.yaml
- title: Tron Wallet
$ref: ./TronWalletExternalAccountInfo.yaml
- title: Polygon Wallet
$ref: ./PolygonWalletExternalAccountInfo.yaml
- title: Base Wallet
$ref: ./BaseWalletExternalAccountInfo.yaml
- title: US Account
$ref: ./UsAccountExternalAccountInfo.yaml
Comment on lines 1 to +3
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Malformed oneOf list

oneOf: must contain a YAML sequence of schemas (each item should be indented under oneOf:), but the current file has oneOf: followed immediately by - title: ... at the same indentation as oneOf:. This makes the oneOf value null and turns the schema entries into top-level keys, which will break bundling/linting and any tooling expecting a valid oneOf.

Suggested change
oneOf:
- title: US Account
$ref: ./UsAccountExternalAccountInfo.yaml
- title: CLABE Account
$ref: ./ClabeAccountExternalAccountInfo.yaml
- title: PIX Account
$ref: ./PixAccountExternalAccountInfo.yaml
- title: IBAN Account
$ref: ./IbanAccountExternalAccountInfo.yaml
- title: UPI Account
$ref: ./UpiAccountExternalAccountInfo.yaml
- title: NGN Account
$ref: ./NgnAccountExternalAccountInfo.yaml
- title: CAD Account
$ref: ./CadAccountExternalAccountInfo.yaml
- title: GBP Account
$ref: ./GbpAccountExternalAccountInfo.yaml
- title: PHP Account
$ref: ./PhpAccountExternalAccountInfo.yaml
- title: SGD Account
$ref: ./SgdAccountExternalAccountInfo.yaml
- title: Spark Wallet
$ref: ./SparkWalletExternalAccountInfo.yaml
- title: Lightning
$ref: ./LightningExternalAccountInfo.yaml
- title: Solana Wallet
$ref: ./SolanaWalletExternalAccountInfo.yaml
- title: Tron Wallet
$ref: ./TronWalletExternalAccountInfo.yaml
- title: Polygon Wallet
$ref: ./PolygonWalletExternalAccountInfo.yaml
- title: Base Wallet
$ref: ./BaseWalletExternalAccountInfo.yaml
- title: US Account
$ref: ./UsAccountExternalAccountInfo.yaml
oneOf:
- title: US Account
$ref: ./UsAccountExternalAccountInfo.yaml
Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml
Line: 1:3

Comment:
**Malformed `oneOf` list**

`oneOf:` must contain a YAML sequence of schemas (each item should be indented under `oneOf:`), but the current file has `oneOf:` followed immediately by `- title: ...` at the same indentation as `oneOf:`. This makes the `oneOf` value `null` and turns the schema entries into top-level keys, which will break bundling/linting and any tooling expecting a valid `oneOf`.

```suggestion
oneOf:
  - title: US Account
    $ref: ./UsAccountExternalAccountInfo.yaml
```

How can I resolve this? If you propose a fix, please make it concise.

- title: CLABE Account
$ref: ./ClabeAccountExternalAccountInfo.yaml
- title: PIX Account
$ref: ./PixAccountExternalAccountInfo.yaml
- title: IBAN Account
$ref: ./IbanAccountExternalAccountInfo.yaml
- title: UPI Account
$ref: ./UpiAccountExternalAccountInfo.yaml
- title: NGN Account
$ref: ./NgnAccountExternalAccountInfo.yaml
- title: CAD Account
$ref: ./CadAccountExternalAccountInfo.yaml
- title: GBP Account
$ref: ./GbpAccountExternalAccountInfo.yaml
- title: PHP Account
$ref: ./PhpAccountExternalAccountInfo.yaml
- title: SGD Account
$ref: ./SgdAccountExternalAccountInfo.yaml
- title: Spark Wallet
$ref: ./SparkWalletExternalAccountInfo.yaml
- title: Lightning
$ref: ./LightningExternalAccountInfo.yaml
- title: Solana Wallet
$ref: ./SolanaWalletExternalAccountInfo.yaml
- title: Tron Wallet
$ref: ./TronWalletExternalAccountInfo.yaml
- title: Polygon Wallet
$ref: ./PolygonWalletExternalAccountInfo.yaml
- title: Base Wallet
$ref: ./BaseWalletExternalAccountInfo.yaml
- title: MXN SPEI Account
$ref: ./MxnSpeiAccountInfo.yaml
- title: INR UPI Account
$ref: ./InrUpiAccountInfo.yaml
discriminator:
propertyName: accountType
mapping:
Expand All @@ -50,3 +54,5 @@ discriminator:
TRON_WALLET: ./TronWalletExternalAccountInfo.yaml
POLYGON_WALLET: ./PolygonWalletExternalAccountInfo.yaml
BASE_WALLET: ./BaseWalletExternalAccountInfo.yaml
MXN_SPEI_ACCOUNT: ./MxnSpeiAccountInfo.yaml
INR_UPI_ACCOUNT: ./InrUpiAccountInfo.yaml
34 changes: 34 additions & 0 deletions openapi/components/schemas/external_accounts/InrUpiAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
type: object
title: INR UPI Account
description: Required fields for USD -> INR corridor via Upi
required:
- accountType
- beneficiary
- vpa
properties:
accountType:
type: string
enum:
- INR_UPI_ACCOUNT
example: INR_UPI_ACCOUNT
paymentRail:
type: string
const: UPI
description: Payment rail. Auto-populated based on account type.
receivingCurrency:
type: string
const: INR
description: Receiving currency code. Auto-populated based on account type.
vpa:
type: string
description: Virtual Payment Address for UPI payments
example: somecustomers@okbank
beneficiary:
type: object
required:
- fullName
properties:
fullName:
type: string
description: Individual's full name
example: John Michael Doe
37 changes: 37 additions & 0 deletions openapi/components/schemas/external_accounts/MxnSpeiAccountInfo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
type: object
title: MXN SPEI Account
description: Required fields for USD -> MXN corridor via Spei
required:
- accountType
- beneficiary
- clabeNumber
properties:
accountType:
type: string
enum:
- MXN_SPEI_ACCOUNT
example: MXN_SPEI_ACCOUNT
clabeNumber:
type: string
description: 18-digit CLABE number (Mexican banking standard)
example: '123456789012345678'
minLength: 18
maxLength: 18
pattern: ^[0-9]{18}$
paymentRail:
type: string
const: SPEI
description: Payment rail. Auto-populated based on account type.
receivingCurrency:
type: string
const: MXN
description: Receiving currency code. Auto-populated based on account type.
beneficiary:
type: object
required:
- fullName
properties:
fullName:
type: string
description: Individual's full name
example: John Michael Doe