chore: Update external account schemas from webdev #151
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| type: object | ||
| title: InrUpiAccountInfo | ||
| description: Required fields for USD -> INR corridor via Upi | ||
| required: | ||
| - accountType | ||
| - beneficiary | ||
| - vpa | ||
|
Comment on lines
+1
to
+7
Contributor
There was a problem hiding this comment. Schema structure inconsistent with existing patterns. Other external account schemas (e.g., Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/InrUpiAccountInfo.yaml
Line: 1:7
Comment:
Schema structure inconsistent with existing patterns. Other external account schemas (e.g., `UpiAccountExternalAccountInfo.yaml:1-9`, `ClabeAccountExternalAccountInfo.yaml:1-9`) use `allOf` composition to extend `BaseExternalAccountInfo.yaml` and reference common account info schemas. This standalone schema doesn't inherit base properties or use the established composition pattern
How can I resolve this? If you propose a fix, please make it concise. |
||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - INR_UPI_ACCOUNT | ||
| example: INR_UPI_ACCOUNT | ||
| vpa: | ||
| type: string | ||
| description: Virtual Payment Address for UPI payments | ||
| example: somecustomers@okbank | ||
| beneficiary: | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: Individual's full name | ||
| example: John Michael Doe | ||
|
Comment on lines
+18
to
+26
Contributor
There was a problem hiding this comment. Beneficiary structure doesn't match existing external account patterns. Other account types (e.g., Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/InrUpiAccountInfo.yaml
Line: 18:26
Comment:
Beneficiary structure doesn't match existing external account patterns. Other account types (e.g., `UpiAccountExternalAccountInfo.yaml:9`, `ClabeAccountExternalAccountInfo.yaml:9`, `NgnAccountExternalAccountInfo.yaml:27`) use `$ref: ./BeneficiaryOneOf.yaml` which supports both individual and business beneficiaries with proper validation. This inline definition only accepts `fullName` without `beneficiaryType`, `birthDate`, or `nationality` fields required by `IndividualBeneficiary.yaml:4-8`
How can I resolve this? If you propose a fix, please make it concise. |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| type: object | ||
| title: MxnSpeiAccountInfo | ||
| description: Required fields for USD -> MXN corridor via Spei | ||
| required: | ||
| - accountType | ||
| - beneficiary | ||
| - clabeNumber | ||
|
Comment on lines
+1
to
+7
Contributor
There was a problem hiding this comment. Schema structure inconsistent with existing patterns. Other external account schemas (e.g., Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/MxnSpeiAccountInfo.yaml
Line: 1:7
Comment:
Schema structure inconsistent with existing patterns. Other external account schemas (e.g., `UpiAccountExternalAccountInfo.yaml:1-9`, `ClabeAccountExternalAccountInfo.yaml:1-9`) use `allOf` composition to extend `BaseExternalAccountInfo.yaml` and reference common account info schemas. This standalone schema doesn't inherit base properties or use the established composition pattern
How can I resolve this? If you propose a fix, please make it concise. |
||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - MXN_SPEI_ACCOUNT | ||
| example: MXN_SPEI_ACCOUNT | ||
| clabeNumber: | ||
| type: string | ||
| description: 18-digit CLABE number (Mexican banking standard) | ||
| example: '123456789012345678' | ||
| minLength: 18 | ||
| maxLength: 18 | ||
| pattern: ^[0-9]{18}$ | ||
| beneficiary: | ||
| type: object | ||
| required: | ||
| - fullName | ||
| properties: | ||
| fullName: | ||
| type: string | ||
| description: Individual's full name | ||
| example: John Michael Doe | ||
|
Comment on lines
+21
to
+29
Contributor
There was a problem hiding this comment. Beneficiary structure doesn't match existing external account patterns. Other account types (e.g., Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/MxnSpeiAccountInfo.yaml
Line: 21:29
Comment:
Beneficiary structure doesn't match existing external account patterns. Other account types (e.g., `UpiAccountExternalAccountInfo.yaml:9`, `ClabeAccountExternalAccountInfo.yaml:9`, `NgnAccountExternalAccountInfo.yaml:27`) use `$ref: ./BeneficiaryOneOf.yaml` which supports both individual and business beneficiaries with proper validation. This inline definition only accepts `fullName` without `beneficiaryType`, `birthDate`, or `nationality` fields required by `IndividualBeneficiary.yaml:4-8`
How can I resolve this? If you propose a fix, please make it concise. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title naming inconsistent with existing patterns. Other entries use descriptive titles like "US Account", "CLABE Account", "UPI Account" but these use schema names "MxnSpeiAccountInfo" and "InrUpiAccountInfo"
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Prompt To Fix With AI