chore: Update external account schemas from webdev #148
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| type: object | ||
| title: InrUpiAccountInfo | ||
| description: Required fields for USD -> INR corridor via Upi | ||
| required: | ||
| - accountType | ||
| - beneficiary | ||
| - fullName | ||
| - vpa | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - INR_UPI_ACCOUNT | ||
| example: INR_UPI_ACCOUNT | ||
| fullName: | ||
| type: string | ||
| description: Full name of the beneficiary | ||
| example: John Michael Doe | ||
| vpa: | ||
| type: string | ||
| description: Virtual Payment Address (UPI) | ||
| example: john@upi | ||
| beneficiary: | ||
| oneOf: | ||
| - $ref: ./IndividualBeneficiary.yaml | ||
| - $ref: ./BusinessBeneficiary.yaml | ||
| discriminator: | ||
| propertyName: beneficiaryType | ||
| mapping: | ||
| INDIVIDUAL: ./IndividualBeneficiary.yaml | ||
| BUSINESS: ./BusinessBeneficiary.yaml | ||
|
Comment on lines
+1
to
+31
Contributor
There was a problem hiding this comment. Schema structure doesn't follow existing patterns. All other external account schemas use
Expected structure: allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/InrUpiAccountInfo.yaml
- type: object
required:
- beneficiary
properties:
beneficiary:
$ref: ./BeneficiaryOneOf.yamlNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/InrUpiAccountInfo.yaml
Line: 1:31
Comment:
Schema structure doesn't follow existing patterns. All other external account schemas use `allOf` with `BaseExternalAccountInfo` and a common schema ref (see `UpiAccountExternalAccountInfo.yaml`). This schema should:
1. Use `allOf` pattern with `BaseExternalAccountInfo.yaml`
2. Reference a common `InrUpiAccountInfo.yaml` schema in `../common/`
3. Use `$ref: ./BeneficiaryOneOf.yaml` for beneficiary instead of inline definition
4. `fullName` should not be duplicated in both top-level and beneficiary (beneficiary already has this field)
Expected structure:
```yaml
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/InrUpiAccountInfo.yaml
- type: object
required:
- beneficiary
properties:
beneficiary:
$ref: ./BeneficiaryOneOf.yaml
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| type: object | ||
| title: MxnSpeiAccountInfo | ||
| description: Required fields for USD -> MXN corridor via Spei | ||
| required: | ||
| - accountType | ||
| - beneficiary | ||
| - clabe | ||
| - name | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - MXN_SPEI_ACCOUNT | ||
| example: MXN_SPEI_ACCOUNT | ||
| clabe: | ||
| type: string | ||
| description: Mexican CLABE interbank account number (18 digits) | ||
| example: 012180001234567890 | ||
| name: | ||
| type: string | ||
| description: Full name of the payee | ||
| example: Jane Smith | ||
| beneficiary: | ||
| oneOf: | ||
| - $ref: ./IndividualBeneficiary.yaml | ||
| - $ref: ./BusinessBeneficiary.yaml | ||
| discriminator: | ||
| propertyName: beneficiaryType | ||
| mapping: | ||
| INDIVIDUAL: ./IndividualBeneficiary.yaml | ||
| BUSINESS: ./BusinessBeneficiary.yaml | ||
|
Comment on lines
+1
to
+31
Contributor
There was a problem hiding this comment. Schema structure doesn't follow existing patterns. All other external account schemas use
Expected structure: allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/MxnSpeiAccountInfo.yaml
- type: object
required:
- beneficiary
properties:
beneficiary:
$ref: ./BeneficiaryOneOf.yamlNote: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/external_accounts/MxnSpeiAccountInfo.yaml
Line: 1:31
Comment:
Schema structure doesn't follow existing patterns. All other external account schemas use `allOf` with `BaseExternalAccountInfo` and a common schema ref (see `ClabeAccountExternalAccountInfo.yaml`, `UpiAccountExternalAccountInfo.yaml`). This schema should:
1. Use `allOf` pattern with `BaseExternalAccountInfo.yaml`
2. Reference a common `MxnSpeiAccountInfo.yaml` schema
3. Use `$ref: ./BeneficiaryOneOf.yaml` for beneficiary instead of inline definition
4. Field `clabe` should be `clabeNumber` (matches existing `ClabeAccountInfo.yaml`)
Expected structure:
```yaml
allOf:
- $ref: ./BaseExternalAccountInfo.yaml
- $ref: ../common/MxnSpeiAccountInfo.yaml
- type: object
required:
- beneficiary
properties:
beneficiary:
$ref: ./BeneficiaryOneOf.yaml
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing updates to related schemas. Adding
MXN_SPEI_ACCOUNTandINR_UPI_ACCOUNTtypes requires updates to:ExternalAccountType.yaml- add enum valuesBaseExternalAccountInfo.yaml- add discriminator mappingsWithout these updates, the new account types won't be recognized as valid values.
Prompt To Fix With AI