From f0c6559de884ce225b23aa6dac982e13a6f329f9 Mon Sep 17 00:00:00 2001 From: Jae Kim Date: Tue, 10 Feb 2026 10:00:47 -0800 Subject: [PATCH] [AI-FSSDK] [FSSDK-12262] Exclude CMAB from UserProfileService --- lib/optimizely/decision_service.rb | 16 +++- spec/decision_service_spec.rb | 128 +++++++++++++++++++++++++++++ 2 files changed, 141 insertions(+), 3 deletions(-) diff --git a/lib/optimizely/decision_service.rb b/lib/optimizely/decision_service.rb index 051a8b6..b090d60 100644 --- a/lib/optimizely/decision_service.rb +++ b/lib/optimizely/decision_service.rb @@ -99,8 +99,16 @@ def get_variation(project_config, experiment_id, user_context, user_profile_trac return VariationResult.new(nil, false, decide_reasons, whitelisted_variation_id) if whitelisted_variation_id should_ignore_user_profile_service = decide_options.include? Optimizely::Decide::OptimizelyDecideOption::IGNORE_USER_PROFILE_SERVICE - # Check for saved bucketing decisions if decide_options do not include ignoreUserProfileService - unless should_ignore_user_profile_service && user_profile_tracker + # CMAB experiments are excluded from UPS because UPS maintains decisions + # across the experiment lifetime without considering TTL or user attributes, + # which contradicts CMAB's dynamic nature. + is_cmab_experiment = experiment.key?('cmab') + if is_cmab_experiment + message = "Skipping user profile service for CMAB experiment '#{experiment_key}'." + @logger.log(Logger::INFO, message) + decide_reasons.push(message) + elsif !(should_ignore_user_profile_service && user_profile_tracker) + # Check for saved bucketing decisions if decide_options do not include ignoreUserProfileService saved_variation_id, reasons_received = get_saved_variation_id(project_config, experiment_id, user_profile_tracker.user_profile) decide_reasons.push(*reasons_received) if saved_variation_id @@ -155,7 +163,9 @@ def get_variation(project_config, experiment_id, user_context, user_profile_trac decide_reasons.push(message) if message # Persist bucketing decision - user_profile_tracker.update_user_profile(experiment_id, variation_id) unless should_ignore_user_profile_service && user_profile_tracker + # Skip UPS save for CMAB experiments - CMAB decisions should not be persisted + # in UPS as they are dynamically determined based on context. + user_profile_tracker.update_user_profile(experiment_id, variation_id) unless should_ignore_user_profile_service && user_profile_tracker || is_cmab_experiment VariationResult.new(cmab_uuid, false, decide_reasons, variation_id) end diff --git a/spec/decision_service_spec.rb b/spec/decision_service_spec.rb index 30ad7d2..ed1b881 100644 --- a/spec/decision_service_spec.rb +++ b/spec/decision_service_spec.rb @@ -1166,5 +1166,133 @@ expect(spy_cmab_service).not_to have_received(:get_decision) end end + + describe 'CMAB UPS exclusion' do + it 'should skip UPS lookup for CMAB experiments even when user profile tracker is available' do + cmab_experiment = { + 'id' => '111150', + 'key' => 'cmab_experiment', + 'status' => 'Running', + 'layerId' => '111150', + 'audienceIds' => [], + 'forcedVariations' => {}, + 'variations' => [ + {'id' => '111151', 'key' => 'variation_1'}, + {'id' => '111152', 'key' => 'variation_2'} + ], + 'trafficAllocation' => [ + {'entityId' => '111151', 'endOfRange' => 5000}, + {'entityId' => '111152', 'endOfRange' => 10_000} + ], + 'cmab' => {'trafficAllocation' => 5000} + } + user_context = project_instance.create_user_context('test_user', {}) + + allow(config).to receive(:get_experiment_from_id).with('111150').and_return(cmab_experiment) + allow(config).to receive(:experiment_running?).with(cmab_experiment).and_return(true) + allow(Optimizely::Audience).to receive(:user_meets_audience_conditions?).and_return([true, []]) + allow(decision_service.bucketer).to receive(:bucket_to_entity_id) + .with(config, cmab_experiment, 'test_user', 'test_user') + .and_return(['$', []]) + allow(spy_cmab_service).to receive(:get_decision) + .with(config, user_context, '111150', []) + .and_return(Optimizely::CmabDecision.new(variation_id: '111151', cmab_uuid: 'test-cmab-uuid-123')) + allow(config).to receive(:get_variation_from_id_by_experiment_id) + .with('111150', '111151') + .and_return({'id' => '111151', 'key' => 'variation_1'}) + + # Spy on get_saved_variation_id to verify it is NOT called + allow(decision_service).to receive(:get_saved_variation_id).and_call_original + + variation_result = decision_service.get_variation(config, '111150', user_context) + + # UPS lookup should NOT be called for CMAB experiments + expect(decision_service).not_to have_received(:get_saved_variation_id) + + # Verify skip reason is in decision reasons + expect(variation_result.reasons).to include( + "Skipping user profile service for CMAB experiment 'cmab_experiment'." + ) + + # Verify CMAB decision was still made correctly + expect(variation_result.variation_id).to eq('111151') + expect(variation_result.cmab_uuid).to eq('test-cmab-uuid-123') + end + + it 'should not save to UPS for CMAB experiments' do + cmab_experiment = { + 'id' => '111150', + 'key' => 'cmab_experiment', + 'status' => 'Running', + 'layerId' => '111150', + 'audienceIds' => [], + 'forcedVariations' => {}, + 'variations' => [ + {'id' => '111151', 'key' => 'variation_1'}, + {'id' => '111152', 'key' => 'variation_2'} + ], + 'trafficAllocation' => [ + {'entityId' => '111151', 'endOfRange' => 5000}, + {'entityId' => '111152', 'endOfRange' => 10_000} + ], + 'cmab' => {'trafficAllocation' => 5000} + } + user_context = project_instance.create_user_context('test_user', {}) + user_profile_tracker = Optimizely::UserProfileTracker.new('test_user', spy_user_profile_service, spy_logger) + + allow(config).to receive(:get_experiment_from_id).with('111150').and_return(cmab_experiment) + allow(config).to receive(:experiment_running?).with(cmab_experiment).and_return(true) + allow(Optimizely::Audience).to receive(:user_meets_audience_conditions?).and_return([true, []]) + allow(decision_service.bucketer).to receive(:bucket_to_entity_id) + .with(config, cmab_experiment, 'test_user', 'test_user') + .and_return(['$', []]) + allow(spy_cmab_service).to receive(:get_decision) + .with(config, user_context, '111150', []) + .and_return(Optimizely::CmabDecision.new(variation_id: '111151', cmab_uuid: 'test-cmab-uuid-123')) + allow(config).to receive(:get_variation_from_id_by_experiment_id) + .with('111150', '111151') + .and_return({'id' => '111151', 'key' => 'variation_1'}) + + # Spy on update_user_profile to verify it is NOT called + allow(user_profile_tracker).to receive(:update_user_profile).and_call_original + + variation_result = decision_service.get_variation(config, '111150', user_context, user_profile_tracker) + + # Verify variation was assigned + expect(variation_result.variation_id).to eq('111151') + + # UPS save should NOT be called for CMAB experiments + expect(user_profile_tracker).not_to have_received(:update_user_profile) + end + + it 'should use UPS normally for non-CMAB experiments' do + user_context = project_instance.create_user_context('test_user', {}) + experiment = config.get_experiment_from_key('test_experiment') + experiment_id = experiment['id'] + + # Set up a stored variation in the user profile + user_profile_tracker = Optimizely::UserProfileTracker.new('test_user', spy_user_profile_service, spy_logger) + user_profile_tracker.instance_variable_set(:@user_profile, { + user_id: 'test_user', + experiment_bucket_map: { + experiment_id => {variation_id: '111128'} + } + }) + + allow(config).to receive(:variation_id_exists?).with(experiment_id, '111128').and_return(true) + + variation_result = decision_service.get_variation(config, experiment_id, user_context, user_profile_tracker) + + # UPS lookup SHOULD return stored variation for non-CMAB experiments + expect(variation_result.variation_id).to eq('111128') + + # Verify no CMAB skip message in reasons + variation_result.reasons.each do |reason| + next if reason.nil? + + expect(reason).not_to include('Skipping user profile service for CMAB experiment') + end + end + end end end