Reduce verbosity of check_graphite when returned values are null#3
Open
chrisweeksnz wants to merge 3 commits intocatalyst:masterfrom
Open
Reduce verbosity of check_graphite when returned values are null#3chrisweeksnz wants to merge 3 commits intocatalyst:masterfrom
chrisweeksnz wants to merge 3 commits intocatalyst:masterfrom
Conversation
Reduce verbosity of response when all returned json values are null.
…erbosity Update check_graphite.py
Remove white space generated by web editor UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a check returns all nulls, the output can be significant and makes navigating icinga alerts tiresome. This change ensures that if the returned JSON is all null, then the returned value is a short string stating the returned JSON is all nulls.