From 54788ba267af6c4eb0f8e8db7be058c8010bbadc Mon Sep 17 00:00:00 2001 From: Douglas Thor Date: Wed, 14 Jan 2026 21:01:09 +0000 Subject: [PATCH 1/4] Add missing #3046 reference to 1.7.0 changelog I've had to reference this a couple times now and keep forgetting that it's not in the changelog haha. I figured I'd remedy that. --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c9f812f3bd..9444de67ed 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -216,6 +216,9 @@ END_UNRELEASED_TEMPLATE from the [20251014] release. * (deps) (bzlmod) Upgraded to `bazel-skylib` version [1.8.2](https://github.com/bazelbuild/bazel-skylib/releases/tag/1.8.2) +* (gazelle) Gazelle will now delete targets that have invalid an invalid `srcs` + attribute (typically because the only `srcs` file was deleted). + [#3046](https://github.com/bazel-contrib/rules_python/pull/3046) [20251014]: https://github.com/astral-sh/python-build-standalone/releases/tag/20251014 From 3fccaef7cd2308578a854dca0b6c0a71de451038 Mon Sep 17 00:00:00 2001 From: Douglas Thor Date: Wed, 14 Jan 2026 23:03:22 +0000 Subject: [PATCH 2/4] oops --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9444de67ed..70ea0b13ec 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -216,7 +216,7 @@ END_UNRELEASED_TEMPLATE from the [20251014] release. * (deps) (bzlmod) Upgraded to `bazel-skylib` version [1.8.2](https://github.com/bazelbuild/bazel-skylib/releases/tag/1.8.2) -* (gazelle) Gazelle will now delete targets that have invalid an invalid `srcs` +* (gazelle) Gazelle will now delete targets that have an invalid `srcs` attribute (typically because the only `srcs` file was deleted). [#3046](https://github.com/bazel-contrib/rules_python/pull/3046) From ea4e92310dfa97d8022adda11e47ba00e028c3cb Mon Sep 17 00:00:00 2001 From: Douglas Thor Date: Fri, 16 Jan 2026 21:37:46 +0000 Subject: [PATCH 3/4] Correct 1.7 to 1.8 --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70ea0b13ec..583d898d04 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -133,6 +133,9 @@ END_UNRELEASED_TEMPLATE [#2949](https://github.com/bazel-contrib/rules_python/issues/2949). * (gazelle deps) rules_go bumped from 0.55.1 to 0.59.0 * (gazelle deps) gazelle bumped from 0.36.0 to 0.47.0 +* (gazelle) Gazelle will now delete targets that have an invalid `srcs` + attribute (typically because the only `srcs` file was deleted). + [#3046](https://github.com/bazel-contrib/rules_python/pull/3046) {#v1-8-0-fixed} ### Fixed @@ -216,9 +219,6 @@ END_UNRELEASED_TEMPLATE from the [20251014] release. * (deps) (bzlmod) Upgraded to `bazel-skylib` version [1.8.2](https://github.com/bazelbuild/bazel-skylib/releases/tag/1.8.2) -* (gazelle) Gazelle will now delete targets that have an invalid `srcs` - attribute (typically because the only `srcs` file was deleted). - [#3046](https://github.com/bazel-contrib/rules_python/pull/3046) [20251014]: https://github.com/astral-sh/python-build-standalone/releases/tag/20251014 From d8b69682189c95c6117a44dc259fed7c3a764f92 Mon Sep 17 00:00:00 2001 From: Douglas Thor Date: Fri, 16 Jan 2026 21:40:06 +0000 Subject: [PATCH 4/4] oh it was already in changelog. Simply add reference. --- CHANGELOG.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 583d898d04..00cac20717 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -133,14 +133,12 @@ END_UNRELEASED_TEMPLATE [#2949](https://github.com/bazel-contrib/rules_python/issues/2949). * (gazelle deps) rules_go bumped from 0.55.1 to 0.59.0 * (gazelle deps) gazelle bumped from 0.36.0 to 0.47.0 -* (gazelle) Gazelle will now delete targets that have an invalid `srcs` - attribute (typically because the only `srcs` file was deleted). - [#3046](https://github.com/bazel-contrib/rules_python/pull/3046) {#v1-8-0-fixed} ### Fixed * (gazelle) Remove {obj}`py_binary` targets with invalid `srcs`. This includes files that are not generated or regular files. + [#3046](https://github.com/bazel-contrib/rules_python/pull/3046) * (runfiles) Fix incorrect Python runfiles path assumption - the existing implementation assumes that it is always four levels below the runfiles directory, leading to incorrect path checks