From 301731fc63291efc7e0f2f0e242de0e0432ed450 Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Sat, 14 Feb 2026 09:36:25 +0000 Subject: [PATCH 1/3] Mockito improvements Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.easymock.EasyMockToMockito?organizationId=YTA5ODhiOTYtNDI5OS00OGY3LTg0NjctNGZiNmI4OTY1ZjY3 Co-authored-by: Moderne --- pom.xml | 4 ++-- .../org/apache/maven/plugins/help/EvaluateMojoTest.java | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index dbac403..15169db 100644 --- a/pom.xml +++ b/pom.xml @@ -244,13 +244,13 @@ org.mockito mockito-core - 4.11.0 + 5.21.0 test org.mockito mockito-junit-jupiter - 4.11.0 + 5.21.0 test diff --git a/src/test/java/org/apache/maven/plugins/help/EvaluateMojoTest.java b/src/test/java/org/apache/maven/plugins/help/EvaluateMojoTest.java index ac6fe6e..5fe15de 100644 --- a/src/test/java/org/apache/maven/plugins/help/EvaluateMojoTest.java +++ b/src/test/java/org/apache/maven/plugins/help/EvaluateMojoTest.java @@ -38,6 +38,7 @@ import static org.apache.maven.api.plugin.testing.MojoExtension.setVariableValueToObject; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.never; import static org.mockito.Mockito.times; import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; @@ -86,7 +87,7 @@ void testEvaluateWithoutExpression(EvaluateMojo mojo) throws Exception { String ls = System.lineSeparator(); verify(log).info(ls + "My result"); - verify(log, times(0)).warn(anyString()); + verify(log, never()).warn(anyString()); verify(expressionEvaluator).evaluate("${project.groupId}"); verify(inputHandler, times(2)).readLine(); } @@ -145,7 +146,7 @@ void testEvaluateForComplexExpression(EvaluateMojo mojo) throws Exception { String stdResult = baos.toString(); assertEquals("project_groupId=org.apache.maven.its.help", stdResult); - verify(log, times(0)).warn(anyString()); + verify(log, never()).warn(anyString()); } /** @@ -181,6 +182,6 @@ void testEvaluateQuiteModeWithOutputOnStdout(EvaluateMojo mojo) throws Exception String stdResult = baos.toString(); assertEquals("org.apache.maven.its.help", stdResult); - verify(log, times(0)).warn(anyString()); + verify(log, never()).warn(anyString()); } } From 6851e4a3adc6458103843fa436ec94492328c5ce Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Sat, 14 Feb 2026 10:45:00 +0100 Subject: [PATCH 2/3] Downgrade Mockito dependencies to version 4.11.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 15169db..f152a5d 100644 --- a/pom.xml +++ b/pom.xml @@ -244,13 +244,13 @@ org.mockito mockito-core - 5.21.0 + 4.11.0 test org.mockito mockito-junit-jupiter - 5.21.0 + 5.11.0 test From bdc8fc82542d2e8e14bdecb4c73df7521e57cdbe Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Sat, 14 Feb 2026 10:45:37 +0100 Subject: [PATCH 3/3] Downgrade Mockito version from 5.11.0 to 4.11.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f152a5d..dbac403 100644 --- a/pom.xml +++ b/pom.xml @@ -250,7 +250,7 @@ org.mockito mockito-junit-jupiter - 5.11.0 + 4.11.0 test