diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index b0e8e7e..bb96e1e 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -19,9 +19,9 @@ jobs: # Python is required because `ct lint` runs Yamale (https://github.com/23andMe/Yamale) and # yamllint (https://github.com/adrienverge/yamllint) which require Python - name: Set up Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v6.1.0 with: - python-version: 3.7 + python-version: 3.13 - name: Set up chart-testing uses: helm/chart-testing-action@v2.1.0 diff --git a/charts/core-dump-handler/README.md b/charts/core-dump-handler/README.md index 026be63..afc2446 100644 --- a/charts/core-dump-handler/README.md +++ b/charts/core-dump-handler/README.md @@ -334,6 +334,7 @@ Daemonset * envFrom: Array of [EnvFromSource](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#envfromsource-v1-core) to inject into main container. * sidecarContainers: Array of [Container](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#container-v1-core) to define as part of the pod. * updateStrategy: [DaemonsetUpdateStrategy](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#daemonsetupdatestrategy-v1-apps) is a struct used to control the update strategy for the DaemonSet. +* mountPropagation: [Mount propagation](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation) mode for core dump volumes. (Default "") Service account: * useToken: automatically create a service account token secret diff --git a/charts/core-dump-handler/templates/_helpers.tpl b/charts/core-dump-handler/templates/_helpers.tpl index 200465f..20ea433 100644 --- a/charts/core-dump-handler/templates/_helpers.tpl +++ b/charts/core-dump-handler/templates/_helpers.tpl @@ -76,16 +76,27 @@ Basically copied from https://github.com/bitnami/charts/blob/master/bitnami/comm {{- define "core-dump-handler.daemonset.container.volumeMounts" -}} - name: host-volume - mountPath: {{ .Values.daemonset.hostDirectory }} - mountPropagation: Bidirectional + mountPath: {{ .Values.daemonset.hostDirectory }} + {{- if .Values.daemonset.mountPropagation }} + mountPropagation: {{ .Values.daemonset.mountPropagation }} + {{- end }} - name: core-volume - mountPath: {{ .Values.daemonset.coreDirectory }} - mountPropagation: Bidirectional + mountPath: {{ .Values.daemonset.coreDirectory }} + {{- if .Values.daemonset.mountPropagation }} + mountPropagation: {{ .Values.daemonset.mountPropagation }} + {{- end }} {{- if .Values.composer.coreEvents }} - name: event-volume mountPath: {{ .Values.daemonset.eventDirectory }} mountPropagation: Bidirectional {{- end }} +{{- if .Values.composer.coreEvents }} +- name: event-volume + mountPath: {{ .Values.daemonset.eventDirectory }} + {{- if .Values.daemonset.mountPropagation }} + mountPropagation: {{ .Values.daemonset.mountPropagation }} + {{- end }} +{{- end }} {{- if .Values.daemonset.mountContainerRuntimeEndpoint }} - mountPath: {{ .Values.daemonset.hostContainerRuntimeEndpoint }} name: container-runtime diff --git a/charts/core-dump-handler/values.yaml b/charts/core-dump-handler/values.yaml index 05f8213..8a4261f 100644 --- a/charts/core-dump-handler/values.yaml +++ b/charts/core-dump-handler/values.yaml @@ -60,6 +60,7 @@ daemonset: envFrom: [] sidecarContainers: [] updateStrategy: {} + mountPropagation: "" serviceAccount: create: true