Skip to content

fix: Give better error message on non-existent device #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DominicOram wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −6
Open

fix: Give better error message on non-existent device #1194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5983eb7
Give better error message on non-existant device
DominicOram Sep 4, 2025
50c5192
Remove device listing from device-not-found error
tpoliaw Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/blueapi/core/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,12 +432,12 @@ def __get_pydantic_core_schema__(
) -> CoreSchema:
def valid(value):
val = self.find_device(value)
if not val or not is_compatible(
val, cls.origin or target, cls.args
):
required = qualified_generic_name(target)
if not val:
raise ValueError(f"Device {value} cannot be found")
elif not is_compatible(val, cls.origin or target, cls.args):
req = qualified_generic_name(target)
raise ValueError(
f"Device {value} is not of type {required}"
f"Device {value} ({type(val)}) is not of type {req}"
)
return val

Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/worker/test_task_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,7 +681,7 @@ def missing_injection(dev: FakeDevice = inject("does_not_exist")) -> MsgGenerato
yield from ()

context.register_plan(missing_injection)
with pytest.raises(ValueError):
with pytest.raises(ValueError, match="Device does_not_exist cannot be found"):
Task(name="missing_injection").prepare_params(context)


Expand Down